search

marocchino / sticky-pull-request-comment

create comment on pull request, if exists update that comment.
MIT License
443 stars 81 forks source link

Place comment identifier at top #1363

Closed NoRePercussions closed 2 months ago

NoRePercussions commented 3 months ago

Resolves #1362

Place the comment identifier at the top to keep it from interrupting markdown structures built by appending to the comment, such as tables, which fail with a comment in the middle of them.

marocchino commented 3 months ago

originally The header was in the front. I think it was moved to the footer because it was pointed out that this was a problem when printing in slack.

Moving to the head seems difficult to do right now because there are backward compatibility issues, but it seems good to add an option so that you can select it to be output as a footer or header.

NoRePercussions commented 3 months ago

Makes sense. Maybe we can wontfix this and instead I’ll propose and PR a patch that bumps the comment to the end of the new message when appending?

marocchino commented 3 months ago

That's a good suggestion.