search

marp-team / marp-cli

A CLI interface for Marp and Marpit based converters
MIT License
1.85k stars 105 forks source link

Replace `is-docker` to `is-inside-container` #544

Closed yhatt closed 1 year ago

yhatt commented 1 year ago

Puppeteer is known that it's hard to run on the virtualized container. Marp CLI has Docker container detection to mitigate that, and apply --no-sandbox into Chromium process if detected.

This PR makes changing to replace is-docker module into is-inside-container, to detect more kind of virtualized containers (e.g. Podman).

is-inside-container still includes Docker container detection from the same version as the current is-docker module, so there should be no degradation in detection.

Related: #543

[!NOTE] I don't know that this replacement will work also on AWS ECS. #543 may be closable if ECS was using Podman.