search

marp-team / marp-cli

A CLI interface for Marp and Marpit based converters
MIT License
1.84k stars 105 forks source link

marp-cli docker pull rate limited #577

Open ankudinov opened 3 months ago

ankudinov commented 3 months ago

I'm facing some random rate limit messages when pulling marp-cli image from internal Gitlab CI (have not seen that when pulling from public Github repo). I'm curious if marp-cli is using free plan on Docker hub? I have definitely seen that causing timeouts for my own container images in the past. Docker Hub rate limiting is explained here. If that's the case, are there any plans to more images to GHRC? If not, would you accept a PR for that?

yhatt commented 3 months ago

The rate limit is associated to the account of user who tried to pull. The pricing plan of our Docker ID (marpteam) should not matter.

To avoid pull rate limit error, I recommend to add the login step by docker login before pull the Docker image within your CI workflow, or try to use Dependency Proxy if you are using GitLab.

Even so, the Docker image is providing just for the convenience to try Marp CLI, and I not recommend to use in the workflow. Installing Marp CLI in CI workflow is more reliable way to use It.

https://github.com/orgs/marp-team/discussions/375#discussioncomment-4191221

ankudinov commented 3 months ago

There is no rate limit on the non-free org. Anyway that explains the issue.
Containers much more convenient to build certain pipelines. For example, the link you provided is covering Github Actions, but not Gitlab CI. With the container in use the logic is very portable.
I'm happy to submit a GH workflow for review to build marp-cli on GHRC (if you are open for that). Github has no rate limit for free or paid accounts. Docker Hub is far from being the best for open source nowadays unfortunately.

yhatt commented 3 months ago

Because you asked "I'm curious if marp-cli is using free plan on Docker hub?", I have thought you are misunderstanding as that the pull rate limit for you will become no limit if https://hub.docker.com/u/marpteam became a non-free org.

the link you provided is covering Github Actions, but not Gitlab CI.

This answer is targeted to GitHub Actions, but the command to run on CI is exactly same: npx @marp-team/marp-cli

Let us continue about publishing the image to the GitHub container registry on another issue #578.