marp-team / marp-cli

A CLI interface for Marp and Marpit based converters
MIT License
1.85k stars 105 forks source link

Add ghrc container #581

Open ankudinov opened 3 months ago

ankudinov commented 3 months ago

Start building marp-cli container on GHRC.
Fixes #578

ankudinov commented 3 months ago

The workflow is currently hardcoded to build on my branch to test before merging.
Do not move out of draft status before changing that.

ankudinov commented 3 months ago

@yhatt I'd appreciate some help explaining the current Dockerfile logic. Unfortunately I have 0 skills in Node and it can be something trivial.
However my build is using existing Dockerfile and fails with the following error:

#10 25.06 Error: Cannot find module './lib/marp-cli.js'

This probably comes from marp-cli.js: https://github.com/marp-team/marp-cli/blob/37cd0084ba9bed7a7fa1714e48a59ee4986c56cc/marp-cli.js#L5

I can not get how this file supposed to be created. The Dockerfile COPY --chown=marp:marp . . definitely not helping.

ankudinov commented 3 months ago

Here is the latest build log for the reference: https://github.com/ankudinov/marp-cli/actions/runs/9383539973/job/25837379955

yhatt commented 3 months ago

Is #515 helpful?

yhatt commented 3 months ago

Marp team is currently using CircleCI to push the image to Docker Hub. The triggers and build steps are following: