search

marp-team / marp-core

The core of Marp converter
MIT License
800 stars 132 forks source link

A Marp constructor option, emoji.twemoji.base, seems not working #343

Closed tais9 closed 1 year ago

tais9 commented 1 year ago

Version of Marp Tool

Marp cli 2.5.0

Operating System

Windows

Environment

How to reproduce

It seems like twemoji.base is not working. Other options like shortcode and unicode work well.
For instance, consider the following config file,

options: emoji: shortcode: ‘twemoji’ unicode: false twemoji: base: ‘/twemoji/assets/‘

The generated html file still has jsDeliver link instead of the specified base option.

Expected behavior

The generated slide deck should have twemojis with the specified base.

Actual behavior

Marp’s recently changed default base (jsDeliver) is used.

Additional information

No response

yhatt commented 1 year ago

Good catch. A following test is obviously wrong 😭

https://github.com/marp-team/marp-core/blob/da3cfbd75cebb84f85b86c79bc541327b2b3aa22/test/marp.ts#L176-L182