size global directive failed in vs code extension 0.8.0

marp-team / marp-vscode

Marp for VS Code: Create slide deck written in Marp Markdown on VS Code

https://marketplace.visualstudio.com/items?itemName=marp-team.marp-vscode

MIT License

1.58k stars 75 forks source link

size global directive failed in vs code extension 0.8.0 #61

Closed fabulist-ssdd closed 5 years ago

fabulist-ssdd commented 5 years ago

Hi, I have tried out new feature for customized css in 0.8.0. It works fine. However, it seems that the size global directive 4:3 has been somehow deactivated. The only size that worked is 16:9, if I use the size: 4:3, the preview won't change. The exported pdf is fine for 4:3 though.

I couldn't confirm whether this is an individual case which is just for my end, or ... any way, I am also using the marp web app installed from chrome, the size directive is ok in there.

Looking forward to your reply, THX.

yhatt commented 5 years ago

Hmm, certainly size global directive seems not to work. It reproduces in a very simple Markdown too.

---
marp: true
size: 16:9
---

marp-vscode v0.8.0 has added an internal plugin to extend Marp for using custom CSS, but it raises error when using size.

I'll try working to fix it. Thank you for reporting! 😄

yhatt commented 5 years ago

It was fixed in v0.8.1. Please update the extension. Sorry for a while of inconvenience.

fabulist-ssdd commented 5 years ago

It was fixed in v0.8.1. Please update the extension. Sorry for a while of inconvenience.

thanx. it works now.