marp-team / marpit

The skinny framework for creating slide deck from Markdown
https://marpit.marp.app/
MIT License
964 stars 46 forks source link

`paginate: hold` at the first page renders page number 0 #365

Closed yhatt closed 1 year ago

yhatt commented 1 year ago

Version of Marp Tool

Marpit v2.5.0

Operating System

Other (fill out in the environment field)

Environment

How to reproduce

Use paginate: hold at first page

Expected behavior

Render the page number "1" for every pages

Actual behavior

Render the page number "0" for every pages

Additional information

paginate: hold is a bit rough because it was not originally proposed in #218 and implemented as a result of working at #359. Probably we should render the correct page number with Math.max(1, n).