search

marpaia / chef-golang

Go library to interact with the Chef server API
Other
77 stars 32 forks source link

Added CreateClient, DeleteClient, CreateNode, DeleteNode functions #30

Closed bigkraig closed 10 years ago

bigkraig commented 10 years ago

I have added these functions to simplify the creation of clients and nodes in Chef.

marpaia commented 10 years ago

All in all, great work, thanks for this! I had two questions that I asked inline, otherwise it looks good to me! Thoughts, @spheromak?

bigkraig commented 10 years ago

I added some comments on your comments. I did notice when I tried to use this against my chef server that it's returning 415s on the CreateClient with no error message, i'm still trying to figure out that one.

The API docs specify a JSON object that you should post to the endpoint, but it uses key names that Chef rejects. I've had nginx dump the post body and compared it to what the API suggests and they are totally different too. I'm hoping to get that figured out later today.

josephholsten commented 10 years ago

Looks useful, I'll def be wanting to use this for my integration tests in discoteq.

bigkraig commented 10 years ago

Everything works around structs now and I dumped the extra node struct

marpaia commented 10 years ago

@bigkraig seems like we got away from this. What's up with this PR? Do you still want it merged?

bigkraig commented 10 years ago

We can punt it, i’ve started to work on https://github.com/go-chef/chef

On Jul 30, 2014, at 5:48 PM, Mike Arpaia notifications@github.com wrote:

@bigkraig seems like we got away from this. What's up with this PR? Do you still want it merged?

— Reply to this email directly or view it on GitHub.

parnurzeal commented 9 years ago

Hi, really want to use the features. Is this gonna merge soon? ;)

marpaia commented 9 years ago

@parnurzeal Apparently not. @bigkraig is working on https://github.com/go-chef/chef, but pull requests are always welcome!