marpaia / chef-golang

Go library to interact with the Chef server API
Other
77 stars 31 forks source link

Add minimal changes to make Chef.Put work #37

Closed sspans closed 10 years ago

sspans commented 10 years ago

Tested by updating node acl's

marpaia commented 10 years ago

@sspans can you write a unit test for this so it doesn't regress?

marpaia commented 10 years ago

@sspans any news on this?

sspans commented 10 years ago

Sure, I'll get to it ASAP.

Apologies for the delay, but I was away on a short holiday.

marpaia commented 10 years ago

@sspans no worries at all

sspans commented 10 years ago

I'm running into some errors while running the tests, same as the one reported here:

https://drone.io/github.com/marpaia/chef-golang/25

Any clues?

marpaia commented 10 years ago

@sspans I opened an issue about that here: https://github.com/ctdk/goiardi/issues/21

I need to sink a few minutes into it to figure it out, since I wasn't the one who added the goiardi stuff.

sspans commented 10 years ago

Here's a simple test for the Put functionlity.

marpaia commented 10 years ago

All tests good?

sspans commented 10 years ago

Yes, with the recent test fixes in master all tests pass:

sten@zem:~/go/src$ go get github.com/marpaia/chef-golang sten@zem:~/go/src$ cd - /home/sten/go/src/github.com/marpaia/chef-golang sten@zem:~/go/src/github.com/marpaia/chef-golang$ wget -q -O- https://github.com/marpaia/chef-golang/pull/37.diff | patch -p1 patching file api.go Hunk #1 succeeded at 273 (offset 3 lines). patching file api_test.go sten@zem:~/go/src/github.com/marpaia/chef-golang$ go test Looking for role: Neo4j In production PASS ok github.com/marpaia/chef-golang 5.144s sten@zem:~/go/src/github.com/marpaia/chef-golang$ go test -v | grep -i put === RUN TestPut --- PASS: TestPut (0.13 seconds)

marpaia commented 10 years ago

Perfect, thanks!