marph91 / thunderbird-joplin-export

Easily export your Thunderbird emails to Joplin.
Mozilla Public License 2.0
28 stars 5 forks source link

Does not export anything w. Thunderbird 115.11.0 and Linux Mint #31

Closed Grydpype closed 4 months ago

Grydpype commented 5 months ago

Addon does not export anything using Thunderbird 115.11.0 and Linux Mint; please advise.

Version 0.0.6 from May 27 Status says "working" Message is: "Joplin Export succeeded, exported 0 emails"

Cheers, kai.

marph91 commented 5 months ago

This seems to be a duplicate of #29 and #23. I will close these issues in favour of this one.

I couldn't reproduce the problem with different OS and Joplin versions unfortunately. So I can just do some guessing:

Grydpype commented 5 months ago

Quick response, thank you. I'll supply whatever is possible, but the "screen" in Thunderbird is only a small popup saying "Joplin Export succeeded, exported 0 emails". Would that really help?

re: your question: no, it did not work in the meantime; but must admit that I did not check if I had the latest version.

This afternoon I deleted the add-on and re-installed it.

Regards, kai.

RobWilkinsonUK commented 5 months ago

One of the things I tried as disconnecting custom CSS. I ws pretty sure that would not make a difference and it did not. It seems to not think an email was selected even though it was.

marph91 commented 5 months ago

Thanks for testing!

It might be related to tabs or windows. I think the current error case is:

  1. We ask Thunderbird to return all selected messages at the active tab.
  2. Thunderbird returns 0 selected messages at the active tab.

The reason for the 0 returned messages could be:

Grydpype commented 5 months ago

OK, understood. Will try to provide something until Thursday.

Cheers, kai.

RobWilkinsonUK commented 5 months ago

I have disabled quickfolders and get the same result: 0 emails.

sve773 commented 5 months ago

It's working, but first you have to open the source mail and then click the "Joplin Export" bottom. Please enable the function like we had in the past to select multiple mail in the e.g. inbox view and export this as block.

Thanks, bye Klaus

marph91 commented 5 months ago

It's working, but first you have to open the source mail and then click the "Joplin Export" bottom.

Thanks for the hint! Finally, I can reproduce it. I always had the source mail open. I wasn't even aware that this panel can be hidden.

Please enable the function like we had in the past to select multiple mail in the e.g. inbox view and export this as block.

The problem is that the add-on didn't change anything. It's a change in Thunderbirds behavior. I will check if how can be solved.

Grydpype commented 5 months ago

I can confirm that the export works flawlessly when used in an opened mail. And yes, I would also greatly appreciate it if the "old" functionality (export w/o opening the mail) could be restored.

Cheers, kai.

RobWilkinsonUK commented 5 months ago

Just to be clear: You have to right click in the source mail to export. Opening the source email and then clicking on the Joplin export' button' in the main ribbon still produces no export. Regards,, Rob

Grydpype commented 5 months ago

That last statement I cannot confirm. I have added the plugin button to the menu bar, and it will not work if the mail is not opened, but once opened the menu bar button will work; I have never used the context menu (which will, however, now also work).

marph91 commented 5 months ago

You can try the release from https://github.com/marph91/thunderbird-joplin-export/releases/tag/v0.0.7 (download the .xpi and install manually in Thunderbird). In my tests, all cases worked.

I will try to release it at the Thunderbird add-on store in the next weeks, if there is no other issue.

RobWilkinsonUK commented 5 months ago

0.0.7 worked well for me. Problem solved. Kudos to you. REgards, Rob

Grydpype commented 5 months ago

Same here; works perfectly; thank you very much!

kai.

jobisoft commented 4 months ago

The problem is that the add-on didn't change anything. It's a change in Thunderbirds behavior. I will check if how can be solved.

The add-on was exploiting a bug (an undocumented behavior), namely using the return value of messageDisplay.getDisplayedMessages() to retrieve the selected messages in the mailTab, even if no messages are displayed.

This bug had been fixed, which caused this add-on to fail.

The correct way to handle this is to determine what type of tab the add-on is working with (mail or messageDisplay) and use these methods:

Hope that helps!