search

marqo-ai / marqo

Unified embedding generation and search engine. Also available on cloud - cloud.marqo.ai
https://www.marqo.ai/
Apache License 2.0
4.57k stars 188 forks source link

onnx requires cmake to be installed #1

Closed danyilq closed 2 years ago

danyilq commented 2 years ago

I've tried to install and test marqo on local but it wasn't able to install the ossx package because it uses the cmake, like in that issue.

easily fixed by just running pip install cmake but might be a bit confusing.

should we include it in readme or try to add cmake as a required package?

jn2clark commented 2 years ago

I plan to remove onnx as a dependency in the near term (i.e. tomorrow). It was being used for a particular model but after implementing and testing it was discovered that there was a degradation in retrieval performance. I think this was coming from some of the operations in the compilation which caused the encoders when doing cross-modal search to be mis-aligned. Feel free to add that requirement to the readme for now though.

pandu-k commented 2 years ago

Nice catch Danyil. Thank you!

jn2clark commented 2 years ago

Onnx was removed in this PR https://github.com/S2Search/marqo/pull/4 which should fix this issue. Going to close this. thanks Danyil!