What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)
In add_documents, we download and cache the images until we send all the images to vectorise.
This may cause memory issues as Marqo is caching too many images.
What is the new behavior (if this is a feature change)?
We preprocess the images to tensors right after downloading. Marqo no long caches the full-sized images anymore.
This strategy significantly improves the memory efficiency of Marqo.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
no
Have unit tests been run against this PR? (Has there also been any additional testing?)
no
Related Python client changes (link commit/PR here)
no
Related documentation changes (link commit/PR here)
no
Other information:
no
Please check if the PR fulfills these requirements
[ ] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes/features)
[ ] Docs have been added / updated (for bug fixes / features)
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) feature
What is the current behavior? (You can also link to an open issue here) In
add_documents, we download and cache the images until we send all the images tovectorise. This may cause memory issues as Marqo is caching too many images.What is the new behavior (if this is a feature change)? We preprocess the images to tensors right after downloading. Marqo no long caches the full-sized images anymore. This strategy significantly improves the memory efficiency of Marqo.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?) no
Have unit tests been run against this PR? (Has there also been any additional testing?) no
Related Python client changes (link commit/PR here) no
Related documentation changes (link commit/PR here) no
Other information: no
Please check if the PR fulfills these requirements
[ ] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes/features)
[ ] Docs have been added / updated (for bug fixes / features)