Closed wanliAlex closed 1 year ago
Please check if the PR fulfills these requirements
[x] The commit message follows our guidelines
[x] Tests for the changes have been added (for bug fixes/features)
[x] Docs have been added / updated (for bug fixes / features)
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) remove theserver_batch_size in add_documents API
server_batch_size
What is the current behavior? (You can also link to an open issue here) we have an argument server_batch_size
What is the new behavior (if this is a feature change)? The argument server_batch_size is removed
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?) Yes
Other information: The related marqo pr is https://github.com/marqo-ai/marqo/pull/527
pytest is passed
Please check if the PR fulfills these requirements
[x] The commit message follows our guidelines
[x] Tests for the changes have been added (for bug fixes/features)
[x] Docs have been added / updated (for bug fixes / features)
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) remove the
server_batch_size
in add_documents APIWhat is the current behavior? (You can also link to an open issue here) we have an argument
server_batch_size
What is the new behavior (if this is a feature change)? The argument
server_batch_size
is removedDoes this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?) Yes
Other information: The related marqo pr is https://github.com/marqo-ai/marqo/pull/527
pytest is passed