marqo-ai / py-marqo

Python client for Marqo
https://marqo.pages.dev/
Apache License 2.0
30 stars 5 forks source link

Add a new index defaults for cloud #38

Closed pandu-k closed 1 year ago

pandu-k commented 1 year ago
pandu-k commented 1 year ago

Conflicting defaults problem

Implementation

  1. have a defaults.py file
  2. create a dict "cloud defaults"
  3. Create a check for API key in the create() method.
  4. Add a "merge defaults" loop that merges args into the cloud defaults dict.
  5. Comment where the cloud defaults will be overridden by the method's default params.

We decide that, for now, the cloud defaults will be overridden by the create method's default params. The reason for this is that none of the method's default params conflict with index defaults dict.

pandu-k commented 1 year ago

Resolved by https://github.com/marqo-ai/py-marqo/pull/42