search

marqs85 / ossc

Open Source Scan Converter
http://junkerhq.net/xrgb/index.php/OSSC
GNU General Public License v3.0
470 stars 63 forks source link

Add video Pre-ADC gain setting #24

Closed paulb-nl closed 6 years ago

paulb-nl commented 6 years ago

The if (memcmp had to be changed back because it was applying the previous value when changing gain settings. It also was not applying the saved gain settings on boot.

The bottom line on Info screen was showing previous menu text if there was no sync.

marqs85 commented 6 years ago

Remaining space on audio fw gets alarmingly low after applying the patch:

Info: (sys_controller.elf) 37 KBytes program size (code + initialized data). Info: 664 Bytes free for stack + heap.

The stack size is more than 680 bytes at worst (set CHECK_STACK_USE on firmware.c), so it can potentially crash CPU or corrupt data. Holding the commit for now.

paulb-nl commented 6 years ago

Displaying the raw value (0-15) instead of 0.5-2.0 increases free space to 796 bytes. Do you think that is enough?

marqs85 commented 6 years ago

With a few other size reductions it might still fit but space gets very tight. In any case, this will merged at the latest when current memory limitation has been properly solved.

paulb-nl commented 6 years ago

Rebased and removed unrelated Info screen commit.