Add the ability to save sort criteria

marqu3s / yii2-behaviors

Collection of Yii2 Behaviors to enhance Grids and ActiveRecord models.

MIT License

11 stars 4 forks source link

Add the ability to save sort criteria #5

Closed ghpeppe closed 6 years ago

ghpeppe commented 6 years ago

Very useful and easy to use extension. I've added the ability to save sort criteria.

marqu3s commented 6 years ago

Hi ghpeppe! Thanks for your contribution. I'll review your code soon.

marqu3s commented 6 years ago

Question: Why did you change composer.json? I can't keep your username in the places where you replaced mine because of BC. Will change it back to mine ok?

ghpeppe commented 6 years ago

Sure. I'm new about composer, and github too, so I made confusion. Sorry.

marqu3s commented 6 years ago

That's fine! I have a request. Please add convertGridSort() function as a static function in your SaveGridOrderBehavior class and replace references to GenLib::convertGridSort() to SaveGridOrderBehavior::convertGridSort(). This way we keep all the needed code together.