search

marquestye / pe

0 stars 0 forks source link

Duplicate detection #1

Open marquestye opened 10 months ago

marquestye commented 10 months ago

image.png

Users are able to add duplicates of the same person with the same details, if unimportant changes are made to some fields. Contacts having the same phone number and email address should be identified as a duplicate.

For example, in the above image, notice how Contact 1 and Contact 2 have the exact same name, phone number and email, which should have been noted as a duplicate. However, since the address is typed differently (Avenue instead of Ave, which is likely to happen), the duplicate contact is allowed to be added.

Also, note how Contact 1 and Contact 3 contain the exact same information, other than the capitalization of the name. This should also be flagged as a duplicate.

Especially when the contact list is big, the user will not be able to notice such duplicates, which should definitely be caught and brought up by the app.

Steps to reproduce:

  1. Use clear to start with an empty contact list
  2. Enter add contact -n Aaron -p 12345678 -a Yishun Ave 7 -e aaron123@gmail.com
  3. Enter add contact -n Aaron -p 12345678 -a Yishun Avenue 7 -e aaron123@gmail.com
  4. Enter add contact -n aaron -p 12345678 -a Yishun Ave 7 -e aaron123@gmail.com
nus-se-bot commented 9 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Too similar contacts able to be saved

Contacts are able to be saved even though they have similar details. In the screenshot below, all contacts only have one different detail (e.g. name / email / address) and they are all accepted as unique users.

image.png

However, in real-life usage, there can't be two unique users that for the same name, email, phone number and address only have one differ.

Perhaps you could reconsider the data validation of what is considered as 'unique'

[original: nus-cs2103-AY2324S1/pe-interim#1143] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

This is a conscious design choice that we made since we feel that there is a non-negligible possibility that a user may share common attributes.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** > we feel that there is a non-negligible possibility that a user may share common attributes Emails and phone numbers are meant to be unique to people. The example commands provided in the UG clearly provide personalized emails, such as `aaron123@gmail.com`, which implies that those attributes are meant to be unique to contacts. In any case, even if it is possible for users to share some attributes, such as their address, it would be very helpful for the app to at least provide a warning/notification message, instead of executing and displaying a success message. As a user, I would very much like to know if I am unintentionally adding a duplicate contact, or if the contact I am adding shares some attribute with another so I can find out the reason.
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** This bug has the potential to cause occasional inconvenience to users. As a job-seeker, the app needs to correctly manage my contacts. Being able to add duplicate attributes to different people is counter-intuitive and could have massive implications if I sent an email to the wrong person or called a wrong number because of this bug.