marrink-lab / vermouth-martinize

Describe and apply transformation on molecular structures and topologies
Apache License 2.0
95 stars 43 forks source link

add boxes to parsers #516

Closed fgrunewald closed 1 year ago

fgrunewald commented 1 year ago

For multiple reasons it would be very useful, when the coordinate parsers would also store the box. I've added this parsing feature to the gro / pdb parser in the least invasive way. The gro solution is not so neat but then again the parser is also entirely out of line with the rest.

For the PDB parser I stored the box in the parser object itself. In my opinion this would be safer and then we can decide when and if to use it with molecules. Unfortunately this doesn't work for the gro file reader so it then becomes a molecule class variable. I'm open to other suggestions, but would rather have it fast than redoing any major part of the parsers

fgrunewald commented 1 year ago

@pckroon what did we agree on with this? Keep as is or make box a molecule attribute?

pckroon commented 1 year ago

Keep it as is, and please open an issue complaining about the gro parser not returning a System; and to add something box-like to System