marrlab / DomainLab

modular domain generalization: https://pypi.org/project/domainlab/
https://marrlab.github.io/DomainLab/
MIT License
42 stars 2 forks source link

benchmark diva alone #553

Closed smilesun closed 1 year ago

smilesun commented 1 year ago
git clone https://github.com/marrlab/DomainLab.git   domainlab_diva
cd domainlab_diva
git checkout fbopt
./run_benchmark_slurm examples/benchmark/pacs_diva_fbopt_alone_es5.yaml 10
DanScarc commented 1 year ago

Running successfully.

DanScarc commented 1 year ago

rst.txt

DanScarc commented 1 year ago

Results before bug in yaml: rst_bug.txt

smilesun commented 1 year ago

'str_diva_multiplier_type': 'gammad_recon'

we probably should not run this option at all.

DanScarc commented 1 year ago

Should we be concerned about this? This has never happened so far to my knowledge.

Screenshot 2023-10-16 at 22 14 59
smilesun commented 1 year ago

could you vim one of them and send a screen shot where the error message occur?

DanScarc commented 1 year ago

error_log.txt

smilesun commented 1 year ago

tks, it is my prlbem, i printed the name "error", will change the code so that "error" would not occur in loggin

smilesun commented 1 year ago

so code is fine

smilesun commented 1 year ago

@DanScarc , fixed in latest commit

https://github.com/marrlab/DomainLab/pull/462/commits/1d6345be904f3eed2b3d0afa4a2d1d8c56beba00

DanScarc commented 1 year ago

Should I rerun again, then?

smilesun commented 1 year ago

no

smilesun commented 1 year ago

post some results tomorrow morning here

DanScarc commented 1 year ago

Perfect, as suspected. I'll post results tomorrow!

DanScarc commented 1 year ago

rst.txt Here you go.

smilesun commented 1 year ago

so most jobs get stopped at iteration 8, i will fix this issue so we could run them long enough https://github.com/marrlab/DomainLab/issues/572

smilesun commented 1 year ago

fixed, could you pull and rerun the same yaml file?

you could delete all historical folders already.

smilesun commented 1 year ago

wait, let me do a last edit to yaml file

DanScarc commented 1 year ago

Running since 10'.

DanScarc commented 1 year ago

Ah ok, then killing jobs now. You tell me when you're sure.

smilesun commented 1 year ago

done, please run now

smilesun commented 1 year ago

snake make should use 3 cores at the moment.

smilesun commented 1 year ago

https://github.com/marrlab/DomainLab/pull/462/commits/4007dc8b52005d9773265d216d2bd27443373147,

use at least this commit

DanScarc commented 1 year ago

Running now

smilesun commented 1 year ago

do we have some intermediate results?

DanScarc commented 1 year ago

Yes. rst.txt

DanScarc commented 1 year ago

Updated results below rst.txt