search

marrlab / DomainLab

modular domain generalization: https://pypi.org/project/domainlab/
https://marrlab.github.io/DomainLab/
MIT License
42 stars 2 forks source link

Val threshold #801

Closed MatteoWohlrapp closed 6 months ago

MatteoWohlrapp commented 6 months ago

Added functionality to only stop once a certain validation accuracy has been reached. Can be specified through the argument val_threshold. If it is not provided, it reverts to previous stopping criteria.

smilesun commented 6 months ago

There is conflict in this branch

codecov-commenter commented 6 months ago

Codecov Report

Attention: Patch coverage is 87.09677% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 95.10%. Comparing base (2d17de4) to head (2a530f5).

Files Patch % Lines
domainlab/algos/msels/a_model_sel.py 66.66% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #801 +/- ## ========================================== - Coverage 95.13% 95.10% -0.03% ========================================== Files 127 127 Lines 5015 5026 +11 ========================================== + Hits 4771 4780 +9 - Misses 244 246 +2 ``` | [Flag](https://app.codecov.io/gh/marrlab/DomainLab/pull/801/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marrlab) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/marrlab/DomainLab/pull/801/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marrlab) | `95.10% <87.09%> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marrlab#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.