search

marrlab / DomainLab

modular domain generalization: https://pypi.org/project/domainlab/
https://marrlab.github.io/DomainLab/
MIT License
42 stars 2 forks source link

Changed path from data to domainlab/zdata #807

Closed MatteoWohlrapp closed 5 months ago

MatteoWohlrapp commented 5 months ago

Still needs testing of PACS tasks on server, but wanted to check if CI runs

MatteoWohlrapp commented 5 months ago

I compared the zdata and data folder; the only difference was from the test_parameter_samples.csv. I copied the content from the data folder, as the only code reference to that file pointed towards that folder.

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.10%. Comparing base (d9c8a62) to head (9b192ed).

:exclamation: Current head 9b192ed differs from pull request most recent head 6f4799f. Consider uploading reports for the commit 6f4799f to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #807 +/- ## ======================================= Coverage 95.10% 95.10% ======================================= Files 127 127 Lines 5026 5026 ======================================= Hits 4780 4780 Misses 246 246 ``` | [Flag](https://app.codecov.io/gh/marrlab/DomainLab/pull/807/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marrlab) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/marrlab/DomainLab/pull/807/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marrlab) | `95.10% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marrlab#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

MatteoWohlrapp commented 5 months ago

Tested on the cluster to run pacs job both within the repository and installed through tar. Should I publish it to Pypi?

smilesun commented 5 months ago

This PR deleted the whole /data folder? but no data is added to /domainlab/zdata or I did that already in previous commit so we won't lose any data if merging this PR?

image

MatteoWohlrapp commented 5 months ago

I checked the difference between the data and zdata folder with diff, which tells you whether files exist in one directory but not the other, or if files with the same name have different sizes or timestamps. The only difference was from the test_parameter_samples.csv, which I copied from the data folder to zdata.

smilesun commented 5 months ago

great, thanks!

smilesun commented 5 months ago

yes, please update pypi then! @MatteoWohlrapp