Introduction of a new argument acc_val to method if_stop breaks compatibility with prior versions of domainlab. Can we make it possible for acc_val to be None? Can it maybe be None by default?
In line 60 shown in [1], the argument self.metric_val["acc"] is hard-coded, and may not exist in specific cases.
Introduction of a new argument
acc_valto methodif_stopbreaks compatibility with prior versions of domainlab. Can we make it possible foracc_valto be None? Can it maybe be None by default? In line 60 shown in [1], the argumentself.metric_val["acc"]is hard-coded, and may not exist in specific cases.[1] https://github.com/marrlab/DomainLab/blob/af8a238645f9e777cc7233fcd5c7802fb27d087f/domainlab/algos/observers/b_obvisitor.py#L60 [2] https://github.com/marrlab/DomainLab/blob/af8a238645f9e777cc7233fcd5c7802fb27d087f/domainlab/algos/msels/a_model_sel.py#L77