search

marrlab / DomainLab

modular domain generalization: https://pypi.org/project/domainlab/
https://marrlab.github.io/DomainLab/
MIT License
42 stars 2 forks source link

Validation accuracy for if_stop in model selection optional, and access value in safer way #813

Closed MatteoWohlrapp closed 5 months ago

MatteoWohlrapp commented 5 months ago

Redid changes introduced when adding the validation threshold optional, to make it compatible with previous domainlab versions.

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.10%. Comparing base (332b9f9) to head (c5f6484).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #813 +/- ## ======================================= Coverage 95.10% 95.10% ======================================= Files 127 127 Lines 5028 5029 +1 ======================================= + Hits 4782 4783 +1 Misses 246 246 ``` | [Flag](https://app.codecov.io/gh/marrlab/DomainLab/pull/813/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marrlab) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/marrlab/DomainLab/pull/813/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marrlab) | `95.10% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marrlab#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

smilesun commented 5 months ago

@agisga, are you fine with this PR? (i.e. approve?) shall I merge it?