search

marrlab / DomainLab

modular domain generalization: https://pypi.org/project/domainlab/
https://marrlab.github.io/DomainLab/
MIT License
40 stars 2 forks source link

Merging mhof dev with gamma_reg_collision and master #820

Closed MatteoWohlrapp closed 4 weeks ago

smilesun commented 2 months ago

@MatteoWohlrapp , please fix #806 first, then merge #806 changes to fbopt (just realized mhof-dev has no CI attached so you never know if your edits were correct.

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 61.71004% with 309 lines in your changes are missing coverage. Please review.

Project coverage is 90.77%. Comparing base (44271c8) to head (5b28c73).

Files Patch % Lines
domainlab/utils/generate_fbopt_phase_portrait.py 0.00% 199 Missing :warning:
domainlab/algos/trainers/fbopt_setpoint_ada.py 75.37% 33 Missing :warning:
domainlab/algos/msels/c_msel_val_top_k.py 29.62% 19 Missing :warning:
domainlab/algos/trainers/fbopt_mu_controller.py 84.03% 19 Missing :warning:
domainlab/models/model_diva.py 72.13% 17 Missing :warning:
domainlab/algos/builder_fbopt_dial.py 44.44% 5 Missing :warning:
domainlab/algos/trainers/train_fbopt_b.py 92.85% 5 Missing :warning:
domainlab/algos/msels/c_msel_setpoint_delay.py 84.21% 3 Missing :warning:
domainlab/algos/trainers/train_dial.py 60.00% 2 Missing :warning:
domainlab/models/model_hduva.py 88.88% 2 Missing :warning:
... and 5 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #820 +/- ## ========================================== - Coverage 95.17% 90.77% -4.41% ========================================== Files 128 137 +9 Lines 5080 5853 +773 ========================================== + Hits 4835 5313 +478 - Misses 245 540 +295 ``` | [Flag](https://app.codecov.io/gh/marrlab/DomainLab/pull/820/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marrlab) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/marrlab/DomainLab/pull/820/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marrlab) | `90.77% <61.71%> (-4.41%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=marrlab#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.