marrlab / DomainLab

modular domain generalization: https://pypi.org/project/domainlab/
https://marrlab.github.io/DomainLab/
MIT License
40 stars 2 forks source link

Gamma reg collision test if different gamma is set correctly #847

Open smilesun opened 1 week ago

smilesun commented 1 week ago

running

https://github.com/marrlab/DomainLab/pull/847/files

error is:

>       exp = Exp(margs)                                                                                                       

tests/test_composite_reg_cmd.py:18:                                                                                            
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
domainlab/exp/exp_main.py:30: in __init__                                                                                      
    self.task = TaskChainNodeGetter(args)()                                                                                    
domainlab/tasks/zoo_tasks.py:47: in __call__                                                                                   
    node = chain.handle(self.request)                                                                                          
domainlab/compos/pcr/p_chain_handler.py:89: in handle                                                                          
    return self._success_node.handle(request)                                                                                  
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = <domainlab.tasks.task_mnist_color.NodeTaskMNISTColor10 object at 0x7f1b1e724ca0>, request = None

    def handle(self, request):
        """This method invoke self.is_myjob() to check which node in the chain should handle the
        request
        :param request: subclass can override request object to be string or function
        :return: light weight AbstractChainNodeHandler
        """
        if self.is_myjob(request):
            return self
        if self._success_node is not None:
            return self._success_node.handle(request)
        err_msg = "option " + str(request) + " does not exist"

E       NotImplementedError: option None does not exist

domainlab/compos/pcr/p_chain_handler.py:95: NotImplementedError
smilesun commented 1 week ago

strange, testing the same yaml file with command line works through.

https://github.com/marrlab/DomainLab/blob/faf7589abf34e2901678b9b6eabfa585ab237851/.github/workflows/ci.yml#L45C48-L45C91