search

marrow / mailer

A light-weight, modular, message representation and mail delivery framework for Python.
MIT License
279 stars 62 forks source link

Delete `optimize` setting from setup.cfg, as it causes .pyc files to be included in the wheel #89

Closed jwodder closed 4 years ago

jwodder commented 4 years ago

The project's setup.cfg currently contains the lines:

[install]
optimize = 1

This has the side effect of causing optimized *.pyc files to be compiled & included in the wheel generated by the bdist_wheel command. Such files have no business being in a wheel, as (a) the files are machine-specific and thus won't be of use to most users, and (b) pip compiles its own set of *.pyc files when installing from a wheel anyway. The setting is also of marginal utility to begin with, as it its intended purpose only takes effect when installing with setup.py install, which is deprecated in favor of installing with pip. This PR thus removes the above lines from setup.cfg.

codecov[bot] commented 4 years ago

Codecov Report

Merging #89 into develop will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #89   +/-   ##
========================================
  Coverage    53.43%   53.43%           
========================================
  Files           25       25           
  Lines         1252     1252           
========================================
  Hits           669      669           
  Misses         583      583

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4208b07...959b56c. Read the comment docs.