search

marrow / mailer

A light-weight, modular, message representation and mail delivery framework for Python.
MIT License
279 stars 62 forks source link

FIX TLS in SMTP.py #94

Closed guptajayesh closed 3 years ago

guptajayesh commented 3 years ago

Added Syntax for TLS host = self.host in TLS SSL Mode for SMTP Connection, Fixes Issues when Using SSL in SMTP

amcgregor commented 3 years ago

Rejected for the same reason as the other PR attempting to correct this in this way: this is the most "hack and slash" way possible to correct the problem, which is an underlying problem "up-stream" in Python's standard library. This is a bug with Python, not with Marrow Mailer. This correction, as mentioned previously, suffers the additional deficit (and feature removal) of being able to set diagnostic logging level prior to the connection attempt. If a hostname is provided early, the connection is initiated within __init__, prior to any opportunity to enable diagnostic logging, which is unacceptable.