Open amcgregor opened 5 years ago
Merging #13 into develop will not change coverage. The diff coverage is
100%
.
@@ Coverage Diff @@
## develop #13 +/- ##
========================================
Coverage 99.54% 99.54%
========================================
Files 30 30
Lines 879 879
========================================
Hits 875 875
Misses 4 4
Impacted Files | Coverage Δ | |
---|---|---|
marrow/schema/meta.py | 100% <100%> (ø) |
:arrow_up: |
marrow/schema/release.py | 100% <100%> (ø) |
:arrow_up: |
marrow/schema/declarative.py | 100% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 98a0f5d...4485034. Read the comment docs.
Migrating to Python 3 as the base for the Marrow ecosystem and embracing all of the glorious modern Python 3.7+ features such as type annotations, Marrow Schema Container objects represent a problem. One does not want this:
Having users of Marrow Mongo's ObjectId field type be forced to declare such a Union is absurd. Especially while we wait for PEP 563 to become more broadly adopted. (/ wait for Python 4.0). In the Marrow Mongo case, each field type should absolutely be concretely aware of the instance attribute getter/setter type; the metaclass just needs to aggregate and populate the Container.annotations appropriately.