search

marrow / web.security

Access control list (ACL) authorization, authentication, and cross-site request forgery (CSRF) protection for WebCore applications.
MIT License
4 stars 3 forks source link

Fix capitalization of predicate names in entry_points #3

Closed djdduty closed 7 years ago

djdduty commented 7 years ago

I guess it could also be possible you meant to do all = All() as a singleton similar to always and never?

On second examination, All and Any won't work as singletons since they need the other predicates in __init__?

codecov-io commented 7 years ago

Codecov Report

Merging #3 into develop will decrease coverage by -23.05%. The diff coverage is n/a.

@@             Coverage Diff              @@
##           develop       #3       +/-   ##
============================================
- Coverage      100%   76.95%   -23.05%     
============================================
  Files            4        6        +2     
  Lines          167      217       +50     
============================================
  Hits           167      167               
- Misses           0       50       +50
Impacted Files Coverage Δ
web/security/permission.py 0% <0%> (ø)
web/security/release.py 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4119bab...2074838. Read the comment docs.

amcgregor commented 7 years ago

No, certainly not pre-singleton like the others, as Any/All will always have arguments. The lower casing is merely for consistency of use of the when helper.