search

marrub-- / GLOOME

No longer under development
59 stars 11 forks source link

Fixed & renamed PickActor flags. #19

Closed j-palomo closed 8 years ago

j-palomo commented 8 years ago

The new PickActor flags were broken, and didn't work as intended. Not only that, but it broke backwards compatibility with the old argument. I've fixed all of that. I also renamed the flags to avoid confusion with the A_PainAttack flags.

DaZombieKiller commented 8 years ago

The only changes I see here are the flags being renamed, you may have forgotten to push all of your changes (your pull request description implies more changes)

j-palomo commented 8 years ago

See here:

enum
{
//  PAF_FORCETID,
//  PAF_RETURNTID
    PICKAF_FORCETID = 1,
    PICKAF_RETURNTID = 2,
};

This enumeration (commented out) didn't have any numbers defined for the values. As a result, PAF_FORCETID = 0, and PAF_RETURNTID = 1. Obviously, this is an issue because...

#define PAF_FORCETID  1
#define PAF_RETURNTID 2

The flags never worked as intended. In the worst case, if you used the argument as it previously was (boolean forcetid), using a value of false will actually set the PAF_FORCETID flag.

DaZombieKiller commented 8 years ago

Ah, okay, didn't pick up on that