2 mining missions visiting the same site both end too early with no mineral excavated

mokun commented 7 months ago

Describe the bug

If no minerals have been excavated on a 664 km mining mission, can it be extended further until some minerals are obtained ?

Expected and unexpected behavior

A mining ends too early with no mineral excavated within the prescribed time frame.

Discuss any potential problems you have and have not ruled out

How would the mission planner calculate the probability of a successful mining mission ?
What risk factors and criteria for success should be considered and well labeled ahead of time ?
What kind of 'safe margin' should be observed, even to the point of accepting the failure of the mission and returning home or not accepting the failure and prolonging the mission to a certain degree ?

Java classes involved

MiningMeta, Mining, EVAOperation

EVAOperation's abortEVA() is responsible for outputing that excessive msgs,

/**
 * Aborts an EVA, if the Person is outside get them to return otherwise end the Task.
 * 
 * @param reason Reason for ending.
 */
protected void abortEVA(String reason) {
    if (reason != null) {
        logger.info(worker, "EVA " + getName() + " aborted: " + reason);
    }

    if (person.isOutside()) {
        setPhase(WALK_BACK_INSIDE);
    }
    else
        endTask();
}

Screenshots The 1st mining mission starts on sol 2

The 1st mining mission starts on sol 3. Still ongoing but is doomed with excessive msgs in stacktrace that EVA Mining a Site aborted: EVA ended.

Stacktrace 01-Adir-03:919.740 (Warning) LivingAccommodations [x2] : [Tiberius] Lander Hab 3 - All beds have been taken (# Registered Beds: 4, Bed Capacity: 4). 01-Adir-03:919.740 (Info) OperateVehicle [x16] : [9.7991 N 30.0798 W] Liberty - Case III: Proceeding to mining site. dist2Dest: 279.387 km distanceToCover: 1.393 km uKPH: 19.75 kph vKPHProposed: 19.75 kph hrsTime: 0.02 hrs Time: 70.522 secs maxAccel: 4.361 m/s2 skillMod: 1.0 lightMod: 0.3 terrainMod: 0.98 idealSpeedMS: 49.667 m/s topSpeedKPH: 19.573 kph idealSpeedKPH: 178.802 kph nextSpeedKPH: 19.573 kph
01-Adir-03:921.121 (Info) TendGreenhouse : [Tiberius - Large Greenhouse 1] Amy Diaz - Looking into growing tissue cultures. 01-Adir-03:923.882 (Info) ReviewMissionPlan : [Tiberius] Aaron Baker - Going over the approval of mission plans. 01-Adir-03:923.882 (Info) AbstractMission : [Tiberius] Ernest Cook - Aborted Mineral Exploration 3-001: Rejected. 01-Adir-03:923.882 (Config) MissionManager : Removing 'Mineral Exploration 3-001' mission. 01-Adir-03:923.882 (Info) ReviewMissionPlan : [Tiberius] Aaron Baker - Did NOT approve Ernest Cook's Mineral Exploration 3-001 mission plan. Total Score: 493.7 [Min: 681.6]. 01-Adir-03:925.262 (Info) Settlement : [System] Investigating mineral site at 10.6299 N 29.7500 W (1.0 km). 01-Adir-03:925.262 (Info) Exploration : [Tiberius] A site has an Exploration Value of 0.0. 01-Adir-03:930.787 (Info) OperateVehicle [x16] : [9.4944 N 30.2002 W] Liberty - Case III: Proceeding to mining site. dist2Dest: 260.021 km distanceToCover: 1.225 km uKPH: 19.75 kph vKPHProposed: 19.75 kph hrsTime: 0.017 hrs Time: 62.008 secs maxAccel: 4.361 m/s2 skillMod: 1.0 lightMod: 0.3 terrainMod: 1.0 idealSpeedMS: 47.937 m/s topSpeedKPH: 19.75 kph idealSpeedKPH: 172.572 kph nextSpeedKPH: 19.75 kph
01-Adir-03:941.843 (Info) OperateVehicle [x16] : [9.1894 N 30.3206 W] Liberty - Case III: Proceeding to mining site. dist2Dest: 240.639 km distanceToCover: 2.396 km uKPH: 19.75 kph vKPHProposed: 19.75 kph hrsTime: 0.034 hrs Time: 121.314 secs maxAccel: 4.361 m/s2 skillMod: 1.0 lightMod: 0.3 terrainMod: 1.0 idealSpeedMS: 46.14 m/s topSpeedKPH: 19.75 kph idealSpeedKPH: 166.103 kph nextSpeedKPH: 19.75 kph
01-Adir-03:951.520 (Info) OperateVehicle [x14] : [8.9224 N 30.4258 W] Liberty - Case III: Proceeding to mining site. dist2Dest: 223.671 km distanceToCover: 1.971 km uKPH: 19.75 kph vKPHProposed: 19.75 kph hrsTime: 0.028 hrs Time: 99.81 secs maxAccel: 4.361 m/s2 skillMod: 1.0 lightMod: 0.3 terrainMod: 1.0 idealSpeedMS: 44.507 m/s topSpeedKPH: 19.747 kph idealSpeedKPH: 160.225 kph nextSpeedKPH: 19.747 kph
01-Adir-03:961.239 (Warning) LivingAccommodations : [Tiberius] Lander Hab 2 - All beds have been taken (# Registered Beds: 4, Bed Capacity: 4). 01-Adir-03:961.239 (Info) OperateVehicle [x14] : [8.6545 N 30.5312 W] Liberty - Case III: Proceeding to mining site. dist2Dest: 206.649 km distanceToCover: 1.323 km uKPH: 19.75 kph vKPHProposed: 19.75 kph hrsTime: 0.019 hrs Time: 66.974 secs maxAccel: 4.361 m/s2 skillMod: 1.0 lightMod: 0.3 terrainMod: 0.98 idealSpeedMS: 42.807 m/s topSpeedKPH: 19.597 kph idealSpeedKPH: 154.104 kph nextSpeedKPH: 19.597 kph
01-Adir-03:972.385 (Info) OperateVehicle [x17] : [8.3469 N 30.6520 W] Liberty - Case III: Proceeding to mining site. dist2Dest: 187.108 km distanceToCover: 1.272 km uKPH: 19.75 kph vKPHProposed: 19.75 kph hrsTime: 0.018 hrs Time: 64.383 secs maxAccel: 4.361 m/s2 skillMod: 1.0 lightMod: 0.3 terrainMod: 0.99 idealSpeedMS: 40.768 m/s topSpeedKPH: 19.706 kph idealSpeedKPH: 146.766 kph nextSpeedKPH: 19.706 kph
01-Adir-03:983.539 (Info) OperateVehicle [x16] : [8.0390 N 30.7726 W] Liberty - Case III: Proceeding to mining site. dist2Dest: 167.553 km distanceToCover: 1.24 km uKPH: 19.75 kph vKPHProposed: 19.75 kph hrsTime: 0.017 hrs Time: 62.771 secs maxAccel: 4.361 m/s2 skillMod: 1.0 lightMod: 0.3 terrainMod: 0.96 idealSpeedMS: 38.621 m/s topSpeedKPH: 19.424 kph idealSpeedKPH: 139.035 kph nextSpeedKPH: 19.424 kph
01-Adir-03:984.933 (Info) Vehicle [x137] : [8.0005 N 30.7877 W] Liberty - AverageRoadLoadSpeed: 20 01-Adir-03:984.933 (Info) Vehicle [x137] : [8.0005 N 30.7877 W] Liberty - AverageRoadLoadPower: 2 01-Adir-03:994.695 (Info) OperateVehicle [x16] : [7.7311 N 30.8932 W] Liberty - Case III: Proceeding to mining site. dist2Dest: 147.994 km distanceToCover: 1.464 km uKPH: 19.75 kph vKPHProposed: 19.75 kph hrsTime: 0.021 hrs Time: 74.102 secs maxAccel: 4.361 m/s2 skillMod: 1.0 lightMod: 0.3 terrainMod: 0.98 idealSpeedMS: 36.345 m/s topSpeedKPH: 19.591 kph idealSpeedKPH: 130.843 kph nextSpeedKPH: 19.591 kph
01-Adir-04:000.273 (Config) MasterClock : - - - - - - - - - - - - - - Sol 4 - - - - - - - - - - - - - - 01-Adir-04:000.273 (Info) Settlement : [Tiberius] On Sol 4, 5.4000 N 31.8000 W was added to be analyzed and explored. 01-Adir-04:000.273 (Info) Settlement : [Tiberius] Overall average # of improvement made on all mineral locations: 31.0 01-Adir-04:001.668 (Info) ExitAirlock [x5] : [Tiberius - EVA Airlock 3] Linda Bell - Not EVA fit to request egress. Current task: Sleeping. 01-Adir-04:005.851 (Info) OperateVehicle [x16] : [7.4231 N 31.0135 W] Liberty - Case III: Proceeding to mining site. dist2Dest: 128.433 km distanceToCover: 1.265 km uKPH: 19.75 kph vKPHProposed: 19.75 kph hrsTime: 0.018 hrs Time: 64.043 secs maxAccel: 4.361 m/s2 skillMod: 1.0 lightMod: 0.3 terrainMod: 0.79 idealSpeedMS: 33.917 m/s topSpeedKPH: 18.2 kph idealSpeedKPH: 122.101 kph nextSpeedKPH: 18.2 kph
01-Adir-04:008.637 (Info) ProposeScientificStudy : [Tiberius] Richard Reed - Finished writing a study proposal for BOT-TI-1-001. 01-Adir-04:010.028 (Info) ScientificStudy : [Tiberius] Richard Reed - Finished writing proposal for BOT-TI-1-001 study. Starting to invite collaborative researchers. 01-Adir-04:015.583 (Info) OperateVehicle [x14] : [7.1542 N 31.1185 W] Liberty - Case III: Proceeding to mining site. dist2Dest: 111.357 km distanceToCover: 1.446 km uKPH: 19.75 kph vKPHProposed: 19.75 kph hrsTime: 0.02 hrs Time: 73.22 secs maxAccel: 4.361 m/s2 skillMod: 1.0 lightMod: 0.3 terrainMod: 1.0 idealSpeedMS: 31.645 m/s topSpeedKPH: 19.75 kph idealSpeedKPH: 113.922 kph nextSpeedKPH: 19.75 kph
01-Adir-04:021.119 (Info) EnterAirlock : [Tiberius - EVA Airlock 3] Todd Adams - Ready to depressurize the chamber. 01-Adir-04:026.636 (Info) OperateVehicle [x16] : [6.8487 N 31.2375 W] Liberty - Case III: Proceeding to mining site. dist2Dest: 91.961 km distanceToCover: 1.431 km uKPH: 19.75 kph vKPHProposed: 19.75 kph hrsTime: 0.02 hrs Time: 72.433 secs maxAccel: 4.361 m/s2 skillMod: 1.0 lightMod: 0.3 terrainMod: 1.0 idealSpeedMS: 28.848 m/s topSpeedKPH: 19.75 kph idealSpeedKPH: 103.854 kph nextSpeedKPH: 19.75 kph
01-Adir-04:030.759 (Info) Sleep : [Tiberius] Albert Peterson - Sleep adjusted for shift starts at 80. Duration: 49 01-Adir-04:037.602 (Info) OperateVehicle [x16] : [6.5455 N 31.3555 W] Liberty - Case III: Proceeding to mining site. dist2Dest: 72.714 km distanceToCover: 1.496 km uKPH: 19.75 kph vKPHProposed: 19.75 kph hrsTime: 0.021 hrs Time: 75.762 secs maxAccel: 4.361 m/s2 skillMod: 1.0 lightMod: 0.3 terrainMod: 1.0 idealSpeedMS: 25.775 m/s topSpeedKPH: 19.749 kph idealSpeedKPH: 92.789 kph nextSpeedKPH: 19.749 kph
01-Adir-04:040.328 (Info) Sleep : [Tiberius] Alice Bailey - Sleep adjusted for shift starts at 80. Duration: 39

... 01-Adir-04:048.470 (Info) OperateVehicle [x16] : [6.2450 N 31.4723 W] Liberty - Case III: Proceeding to mining site. dist2Dest: 53.637 km distanceToCover: 2.071 km uKPH: 19.75 kph vKPHProposed: 19.75 kph hrsTime: 0.029 hrs Time: 104.873 secs maxAccel: 4.361 m/s2 skillMod: 1.0 lightMod: 0.3 terrainMod: 1.0 idealSpeedMS: 22.315 m/s topSpeedKPH: 19.75 kph idealSpeedKPH: 80.332 kph nextSpeedKPH: 19.75 kph
01-Adir-04:059.237 (Info) OperateVehicle [x16] : [5.9473 N 31.5879 W] Liberty - Case III: Proceeding to mining site. dist2Dest: 34.737 km distanceToCover: 2.082 km uKPH: 19.75 kph vKPHProposed: 19.75 kph hrsTime: 0.029 hrs Time: 105.41 secs maxAccel: 4.361 m/s2 skillMod: 1.0 lightMod: 0.3 terrainMod: 1.0 idealSpeedMS: 18.251 m/s topSpeedKPH: 19.717 kph idealSpeedKPH: 65.702 kph nextSpeedKPH: 19.717 kph
01-Adir-04:064.583 (Info) Sleep : [Tiberius] Maria Jackson - Sleep adjusted for shift starts at 80. Duration: 15

01-Adir-04:069.905 (Info) OperateVehicle [x16] : [5.6522 N 31.7022 W] Liberty - Case III: Proceeding to mining site. dist2Dest: 16.011 km  distanceToCover: 1.494 km  uKPH: 19.75 kph  vKPHProposed: 19.75 kph  hrsTime: 0.021 hrs  Time: 75.653 secs  maxAccel: 4.361 m/s2  skillMod: 1.0  lightMod: 0.3  terrainMod: 1.0  idealSpeedMS: 13.029 m/s  topSpeedKPH: 19.75 kph  idealSpeedKPH: 46.903 kph  nextSpeedKPH: 19.75 kph  
...
01-Adir-04:079.161 (Info) OperateVehicle : [5.4000 N 31.8000 W] Liberty - Case I: Arrived at mining site (dist: 0.0 km).
01-Adir-04:079.161 (Warning) DriveGroundVehicle : [5.4000 N 31.8000 W - Liberty] Peggy Evans - No longer piloting Liberty.
01-Adir-04:079.161 (Info) EVAOperation : [5.4000 N 31.8000 W - Liberty] Peggy Evans - EVA Mining a Site aborted: EVA ended.
01-Adir-04:079.161 (Info) AbstractMission [x4] : [5.4000 N 31.8000 W - Liberty] Peggy Evans - Assigned with 'Mining a Site' to replace 'Driving Vehicle'.
01-Adir-04:080.478 (Info) EVAOperation : [5.4000 N 31.8000 W - Liberty] Sean Murphy - EVA Mining a Site aborted: EVA ended.
01-Adir-04:080.478 (Info) AbstractMission [x2] : [5.4000 N 31.8000 W - Liberty] Sean Murphy - Assigned with 'Mining a Site' to replace 'Consolidating Containers'.
01-Adir-04:080.478 (Info) EVAOperation : [5.4000 N 31.8000 W - Liberty] Sean Murphy - EVA Mining a Site aborted: EVA ended.
01-Adir-04:083.106 (Warning) LivingAccommodations : [Tiberius] Lander Hab 3 -  All beds have been taken (# Registered Beds: 4, Bed Capacity: 4).
01-Adir-04:083.106 (Info) EVAOperation : [5.4000 N 31.8000 W - Liberty] Sean Murphy - EVA Mining a Site aborted: EVA ended.
01-Adir-04:083.106 (Info) EVAOperation : [5.4000 N 31.8000 W - Liberty] Sean Murphy - EVA Mining a Site aborted: EVA ended.
01-Adir-04:085.729 (Info) EVAOperation : [5.4000 N 31.8000 W - Liberty] Sean Murphy - EVA Mining a Site aborted: EVA ended.
01-Adir-04:087.039 (Info) EVAOperation : [5.4000 N 31.8000 W - Liberty] Sean Murphy - EVA Mining a Site aborted: EVA ended.
01-Adir-04:087.039 (Info) CookMeal : [Tiberius] ChefBot 002 - Finished cooking Veggie Burger.
01-Adir-04:090.958 (Info) CookMeal [x3] : [Tiberius] Linda Bell - Finished cooking Veggie Burger.
01-Adir-04:093.563 (Info) CookMeal : [Tiberius] Wanda Torres - Finished cooking Veggie Burger.
01-Adir-04:100.052 (Info) EVAOperation : [5.4000 N 31.8000 W - Liberty] Sean Murphy - EVA Mining a Site aborted: EVA ended.
01-Adir-04:101.347 (Info) Farming : [Tiberius] Inflatable Greenhouse 3 - 0.35 kg Potato Tissue was fully available.
01-Adir-04:101.347 (Info) Crop : [Tiberius - Inflatable Greenhouse 3] Potato - Done growing its tissue-culture. Transferring plantflets to the field.
01-Adir-04:101.347 (Info) Farming : [Tiberius - Inflatable Greenhouse 3] Amy Diaz - Planted a new crop of Potato.
01-Adir-04:102.642 (Info) EVAOperation : [5.4000 N 31.8000 W - Liberty] Sean Murphy - EVA Mining a Site aborted: EVA ended.
01-Adir-04:103.938 (Info) EVAOperation : [5.4000 N 31.8000 W - Liberty] Sean Murphy - EVA Mining a Site aborted: EVA ended.
01-Adir-04:105.233 (Info) EVAOperation : [5.4000 N 31.8000 W - Liberty] Sean Murphy - EVA Mining a Site aborted: EVA ended.
01-Adir-04:106.529 (Info) EVAOperation : [5.4000 N 31.8000 W - Liberty] Sean Murphy - EVA Mining a Site aborted: EVA ended.
01-Adir-04:107.825 (Info) CookMeal : [Tiberius] Billy Williams - Finished cooking Veggie Burger.
01-Adir-04:107.825 (Info) EVAOperation : [5.4000 N 31.8000 W - Liberty] Sean Murphy - EVA Mining a Site aborted: EVA ended.
01-Adir-04:107.825 (Info) EVAOperation : [5.4000 N 31.8000 W - Liberty] Sean Murphy - EVA Mining a Site aborted: EVA ended.
01-Adir-04:109.121 (Info) EVAOperation : [5.4000 N 31.8000 W - Liberty] Sean Murphy - EVA Mining a Site aborted: EVA ended.
01-Adir-04:110.417 (Info) EVAOperation : [5.4000 N 31.8000 W - Liberty] Sean Murphy - EVA Mining a Site aborted: EVA ended.
01-Adir-04:110.417 (Info) Converse : [5.4000 N 31.8000 W - Liberty] Sean Murphy - Unable to find anyone to chat with in Liberty
01-Adir-04:110.417 (Info) EVAOperation : [5.4000 N 31.8000 W - Liberty] Sean Murphy - EVA Mining a Site aborted: EVA ended.
01-Adir-04:111.714 (Info) EVAOperation : [5.4000 N 31.8000 W - Liberty] Sean Murphy - EVA Mining a Site aborted: EVA ended.
01-Adir-04:111.714 (Info) EVAOperation : [5.4000 N 31.8000 W - Liberty] Sean Murphy - EVA Mining a Site aborted: EVA ended.
01-Adir-04:114.307 (Info) EVAOperation : [5.4000 N 31.8000 W - Liberty] Sean Murphy - EVA Mining a Site aborted: EVA ended.
01-Adir-04:115.604 (Info) EVAOperation : [5.4000 N 31.8000 W - Liberty] Sean Murphy - EVA Mining a Site aborted: EVA ended.
01-Adir-04:118.198 (Info) EVAOperation : [5.4000 N 31.8000 W - Liberty] Sean Murphy - EVA Mining a Site aborted: EVA ended.
01-Adir-04:118.198 (Info) CookMeal [x2] : [Tiberius] ChefBot 001 - Finished cooking Veggie Burger.
01-Adir-04:119.495 (Info) CookMeal : [Tiberius] Andrew Martin - Finished cooking Veggie Burger.
01-Adir-04:119.495 (Info) EVAOperation : [5.4000 N 31.8000 W - Liberty] Sean Murphy - EVA Mining a Site aborted: EVA ended.
...
01-Adir-04:128.577 (Info) EVAOperation : [5.4000 N 31.8000 W - Liberty] Peggy Evans - EVA Mining a Site aborted: EVA ended.
01-Adir-04:129.874 (Info) EVAOperation : [5.4000 N 31.8000 W - Liberty] Peggy Evans - EVA Mining a Site aborted: EVA ended.
01-Adir-04:136.363 (Info) EVAOperation : [5.4000 N 31.8000 W - Liberty] Sean Murphy - EVA Mining a Site aborted: EVA ended.
01-Adir-04:137.661 (Info) EVAOperation : [5.4000 N 31.8000 W - Liberty] Sean Murphy - EVA Mining a Site aborted: EVA ended.
01-Adir-04:137.661 (Info) EVAOperation : [5.4000 N 31.8000 W - Liberty] Sean Murphy - EVA Mining a Site aborted: EVA ended.
01-Adir-04:140.257 (Info) EVAOperation : [5.4000 N 31.8000 W - Liberty] Sean Murphy - EVA Mining a Site aborted: EVA ended.
01-Adir-04:141.555 (Info) EVAOperation : [5.4000 N 31.8000 W - Liberty] Peggy Evans - EVA Mining a Site aborted: EVA ended.
01-Adir-04:142.853 (Info) EVAOperation : [5.4000 N 31.8000 W - Liberty] Peggy Evans - EVA Mining a Site aborted: EVA ended.
01-Adir-04:145.448 (Info) EVAOperation : [5.4000 N 31.8000 W - Liberty] Peggy Evans - EVA Mining a Site aborted: EVA ended.
01-Adir-04:146.746 (Info) EVAOperation : [5.4000 N 31.8000 W - Liberty] Peggy Evans - EVA Mining a Site aborted: EVA ended.

Specifications -pre 3.7.0 build 8962

Additional context

Need flexibility to extend EVA site time
Need a grain of salt when considering a 2nd mining mission to the same site

mokun commented 1 month ago

EVA Mining a Site aborted: EVA ended.

@bevans2000

Have you seen this ?

When the EVA ends, members are disbanded.

They aren't supposed to be disbanded until they all traveled back, right ?

bevans2000 commented 1 month ago

Correct, they can only disband at a Settlement. But I might know what the problem is, the abortEVA might not be aware it's a Mission. I will take a look. I want to create UnitTest tests for the Tasks associated to Missions. I'm just working on all the Medical tasks

mokun commented 2 days ago

I have couple of mining missions.

While it said "Completed". They actually all failed.

No mineral excavated. Settlers mysteriously return home.

I was looking at Sara's Person Unit Window, she got stuck inside rover Desert Rat and without a EVA suit.
She cannot leave the rover. Desert Rat also did not report she was inside.
Lena LaGranda was previously inside the rover but somehow beamed back to the settlement.
Lena LaGranda was the mission leader of this mining mission.
Somehow all distances are zero.
Many info were captured incorrectly.
It should state why "EVA operation halted."
It said it has "Traveling" phases but the "Traveled Distance" is still zero.
All crew members were disbanded as expected from a "Completed" mission.
No minerals were found.

bevans2000 commented 2 days ago

My view is the existing Mission framework is spaghetti coding and impossible to test. We need to look forward to the new approach that should be more stable and fully unit tested.

mars-sim / mars-sim

2 mining missions visiting the same site both end too early with no mineral excavated #1144