search

mars / create-react-app-buildpack

⚛️ Heroku Buildpack for create-react-app: static hosting for React.js web apps
MIT License
3.28k stars 653 forks source link

Allow ENV_DIR to be empty string if it is not given #94

Closed banyan closed 5 years ago

banyan commented 6 years ago

I'm using deis v1 and deis v2. deis v2 is okay but deis v1 doesn't pass ENV_DIR. https://github.com/deis/slugbuilder/pull/85 Can we allow ENV_DIR to be empty string if it is not given?

I was getting this error: 

...
remote: -----> Fetching custom buildpack
remote: -----> React.js (create-react-app) multi app detected
remote: /tmp/buildpacks/custom/bin/compile: line 23: $3: unbound variable

refs:

mars commented 6 years ago

Hi @banyan , thank you for your contribution!

This change does make sense, and it seems like it's backward compatible, but I think further change will be required in the inner buildpack too.

banyan commented 6 years ago

@mars

Thanks!! I've sent a PR to inner buildpack too! https://github.com/mars/create-react-app-inner-buildpack/pull/9

mars commented 5 years ago

Closing because the bin/compile arg containing ENV_DIR should allows be provided.