search

mars / heroku-cra-node

⚛️ How to use create-react-app with a custom Node server on Heroku
MIT License
927 stars 226 forks source link

Update CRA packages to current versions #14

Closed artbohr closed 6 years ago

artbohr commented 6 years ago

Hey, this repository helped me a lot to start my heroku cra-node project, but I had some issues which were related to the CRA packages being outdated. One concrete example is the marked package, which has discovered vulnerabilities from the versions this repository proposes, even github shows you a warning if you upload the repo as it is. Updating the lock-json file is a huge headache, so I replaced the package and package-lock to the most current versions from the official CRA repo to get all the perks from the new versions and get rid of the vulnerabilities, I hope it helps, cheers!

mars commented 6 years ago

Thanks @artbohr! I’ve been meaning to do this 😳 I’ll merge once I have a chance to verify functionality.

mars commented 6 years ago

Closing in favor of #15, rebased to get a Heroku Review App deployment.

mars commented 6 years ago

🍻