JS_RUNTIME_TARGET_BUNDLE missing quotes

mars / heroku-cra-node

⚛️ How to use create-react-app with a custom Node server on Heroku

MIT License

927 stars 226 forks source link

Closed keswatt closed 4 years ago

keswatt commented 4 years ago

In README.md change from (no quotes):

2. Set the bundle location for runtime config injection:
    heroku config:set JS_RUNTIME_TARGET_BUNDLE=/app/react-ui/build/static/js/*.js

to (added quotes):

2. Set the bundle location for runtime config injection:
    heroku config:set JS_RUNTIME_TARGET_BUNDLE="/app/react-ui/build/static/js/*.js"

mars commented 4 years ago

Thanks. Good catch!

Revised it to use single quotes, since the glob should not be evaluated until it’s used in the dyno runtime.