ug/maxes and listen/quality-filter will throw NPE if any :speaker-qualitys in utterances passed to quality-filter are nil. (a) Should this throw an exception, or should it be silently ignored? If ignored, how are the utterances containing nil to be evaluated? Included in output, or excluded? Either could cause bugs. (b) Should there be a special exception, or just the NPE thrown by maxes? That would be confusing, and require a little tracking down, but there's no convenient and efficient place to check for the nils, except in maxes, in which case it will only be a little more informative.
ug/maxes
andlisten/quality-filter
will throw NPE if any:speaker-quality
s in utterances passed toquality-filter
arenil
. (a) Should this throw an exception, or should it be silently ignored? If ignored, how are the utterances containing nil to be evaluated? Included in output, or excluded? Either could cause bugs. (b) Should there be a special exception, or just the NPE thrown bymaxes
? That would be confusing, and require a little tracking down, but there's no convenient and efficient place to check for thenil
s, except inmaxes
, in which case it will only be a little more informative.