marsbard / puppet-alfresco

A puppet build script for Alfresco
MIT License
25 stars 11 forks source link

guard against broken downloads #61

Closed marsbard closed 9 years ago

marsbard commented 9 years ago

do not download files into place. download to temp location and move them in, the 'creates' clause of the download resource should refer to the moved file, not the download location

marsbard commented 9 years ago

yay! https://gist.github.com/marsbard/0461444e2c8b11c5656f

marsbard commented 9 years ago

few more things to add to the define before putting this one away

 10   exec { "retrieve-jsconsole":
 11     user => 'tomcat',
 12     timeout => 0,
 13     creates => "${download_path}/${filename_jsconsole}",
 14     command => "wget ${url_jsconsole} -O ${download_path}/${filename_jsconsole}",
 15     path => "/usr/bin",
 16     require => File["${download_path}/jsconsole"],
 17   }

user and timeout - they can default to the values here

marsbard commented 9 years ago

fixed