search

marshallpierce / rust-base64

base64, in rust
Apache License 2.0
617 stars 115 forks source link

Fix DecoderReader handling of padding #238

Closed marshallpierce closed 1 year ago

marshallpierce commented 1 year ago

Fixes #226.

DecoderReader now keeps more state so that erroneous internal padding that happens to fall right on a read buffer boundary isn't silently ignored.

danielabrozzoni commented 1 year ago

Hey, is there any reason why this PR should update the crate MSRV? We're using base64 in https://github.com/bitcoindevkit/rust-esplora-client and we'd like to keep 1.57.0 as our MSRV, but at the same time we would prefer not to pin base64 to "0.21.0" as we'd like to have this bug fix in. Thanks!

marshallpierce commented 1 year ago

Huh, I figured that was old enough most people won't care, but I can roll that back. 1.60 is needed to build the dev dependencies, but for the main code, 1.57 is still fine. I'll release another version with that change.

danielabrozzoni commented 1 year ago

That would be great! Thanks :)

marshallpierce commented 1 year ago

Fix incoming in https://github.com/marshallpierce/rust-base64/pull/239

marshallpierce commented 1 year ago

0.21.2 is out with the fix.