search

marshallswain / feathers-pinia

Connect your Feathers API to the elegant data store for Vue
52 stars 22 forks source link

createClient for non dove api users #109

Closed ericuldall closed 1 year ago

ericuldall commented 1 year ago

Can we get an example of createClient for users who are not on feathers api v5?

marshallswain commented 1 year ago

Yes! There is one in the Common Patterns section, here: https://v2.feathers-pinia.pages.dev/guide/common-patterns.html#feathers-clients-manual-setup

It would be good to refactor it to be called createClient, like you mention. Can you point me to a specific place it would be valuable to link to the common patterns page? It seems likely that we need another link that points there.

ericuldall commented 1 year ago

I read that, I think maybe I was thrown off (not sure why, maybe just a typo) but I think:

import { feathers } from '@feathersjs/feathers'

Should be

import feathers from '@feathersjs/feathers'

I ended up just looking at my original working implementation from feathers-vuex and got it working tho. Slowly starting to learn all the new conventions. :D

ericuldall commented 1 year ago

RE: Where to put it in docs

image

It should be another tab there.

marshallswain commented 1 year ago

The 3.0 docs have great client docs, now.