marshallswain / feathers-pinia

Connect your Feathers API to the elegant data store for Vue
52 stars 22 forks source link

feat: Add type annotations to PiniaService #145

Closed Granipouss closed 8 months ago

Granipouss commented 10 months ago

Hi,

Following issues I had with types (see https://github.com/marshallswain/feathers-pinia/issues/143 & https://github.com/marshallswain/feathers-pinia/issues/144), here is a proposal to improve the situation a bit.

There remains type errors is the tests, mostly because the contact model is extended (with birthdate and description)

Solved

This is mostly a quick fix, I found the typing is still a bit lacking, if you want I can look deeper into it and try to annotate the stores and composables.

Cheers,

marshallswain commented 8 months ago

Thank you for this. I'll release it today.