search

marshallward / vim-restructuredtext

Syntax file for reStructuredText on Vim.
26 stars 12 forks source link

Do not specify colors directly for bold/italic syntax #31

Closed rhysd closed 6 years ago

rhysd commented 6 years ago

In syntax/rst.vim, colors for italic/bold syntax are directly specified in CUI version of Vim as high-contrast purple and red. This is not useful for low-contrast colorschemes. Here is one example I'm using:

screenshot

I removed the colors following the same manner as syntax/html.vim.

marshallward commented 6 years ago

Thanks for sending this. The issue here is that there are terminal emulators (or maybe just fonts) which do not render italics or bold, and the only way to highlight these regions is to use colors.

I agree with your point that explicitly setting of a color in the 16-color terminal palette is not a great solution, but I think that the regions need to be indicated in some way.

This was discussed in #4 but the resolution was not ideal. Happy to either discuss further here or in #4.

rhysd commented 6 years ago

ok, I understood the situation. Thank you for your explanation. Let's discuss about this in the issue (though it was already closed).

rhysd commented 6 years ago

@marshallward I merged your PR to my fork and then rebased this PR onto the master. Thank you for creating a change based on my suggestion at #4.

marshallward commented 6 years ago

Thanks! Sorry if that felt too pedantic, didnt want to commit something under your name in case you were unhappy about it.

rhysd commented 6 years ago

Thank you for considering that :+1: