marshevms / mlfc

MSI Laptop Fan Control
MIT License
61 stars 3 forks source link

Instructions unclear. Got folders but do not contain specified files #39

Open aveemashfaq opened 2 years ago

aveemashfaq commented 2 years ago

I followed the instructions given, installed dependencies and compiled using CMake in Arch Linux. The build was successful. But don't know what to deploy or where to deploy. Please refer to the screenshots of output after compilation

image image image image
marshevms commented 2 years ago

Hello! Thanks for the feedback! Do you exec make?

aveemashfaq commented 2 years ago

Ah, I think after the cmake command in the instructions, the make command was missing.

On a tangent, I executed it and got the below error

image

You can see above that tomlplusplus package is installed. Yet, it is telling me that toml++ version not found. Can you help me here?

marshevms commented 2 years ago

I think it will be easier if you install it from deb package. https://github.com/marshevms/mlfc/releases/tag/0.5.2 https://www.makeuseof.com/install-deb-packages-arch-linux/

aveemashfaq commented 2 years ago

Hi, tried using the debtap to install package. Did not work. Threw an error that mlfc_server not found. I saw the .tar.xz and manually copied files. Found a small error and fixed

`$ mlfc_client

/usr/local/bin/mlfc_client: line 37: /usr/local/bin/bin/mlfc_client: No such file or directory ` Fixed it and now mlfc_client works but is giving me this error message

`$ mlfc_client

/bin/sh: warning: shell level (1000) too high, resetting to 1 `

And it opens up nothing. Is there anything else I can do

marshevms commented 2 years ago

I think you did something wrong, but i don't know what

aveemashfaq commented 2 years ago

Hi, I finally got it working by manually copying files from deb into the folders. Maybe there are a few mistakes in the tar.xz version attached in the release notes.

On a related note, if it is just copy pasting, maybe you can package the app as tar.xz with an install.sh script that copies the relevant files to the relevant paths.

I finally got the GUI working but getting this error

image
marshevms commented 2 years ago

What laptop model?

aveemashfaq commented 2 years ago

MSI Modern 14 B5M. Ryzen 5 -5500U

All MSI laptops apparently use the same EC register values. I'm looking for fan profiles (spin down fans when not needed) and charge limiter.

Currently using this to spin down fans - https://github.com/FaridZelli/ISW-Modern

marshevms commented 2 years ago

Okay, then you need to disable other applications that can modify the ec file and restart the laptop and then open mlfc. And also delete the file from error message

aveemashfaq commented 2 years ago

It works. Removed ISW and now it works. The only thing is that, for some reason, the application is not responsive. It takes around 5 seconds to register a click. Don't know why