Modernize package - Githubissues

marshmallow-code / apispec-webframeworks

Web framework plugins for apispec (formally in apispec.ext).

MIT License

32 stars 23 forks source link

Modernize package #108

Closed kasium closed 8 months ago

kasium commented 1 year ago

Since I working on #103 I found some things to improve

Drop python 3.6 and 3.7 support
Replace pkg_resources with importlib.metadata
Update versions used by pre-commit
Use modern packging based on pyproject.toml
Add support for python3.10/11/12

I'm happy to provide the necessary PR

lafrech commented 1 year ago

Hi. That would be awesome!

I don't have a strict objection to pyproject.toml but I'd rather keep things here consistent with other marshmallow-code packages.

We should fix CI before, or in this PR, by moving to Github Actions (see https://github.com/marshmallow-code/marshmallow/pull/2098). @sloria do you think you could add PYPI_API_KEY (and/or make me maintainer) so that we can proceed? (And likewise for marshmallow-oneofschema.)

Thanks!

kasium commented 1 year ago

@lafrech I'm happy to try the GitHub Action migration first. I guess somewhen next week I'll find some time to try that

lafrech commented 1 year ago

Le Sun, 06 Aug 2023 04:11:19 -0700, kasium @.***> a écrit :

@lafrech I'm happy to try the GitHub Action migration first. I guess somewhen next week I'll find some time to try that

Great. We only need the PYPI API key to release but we can start working on the transition to GHA without it. It should be relatively easy to copy the configuration from the other marshmallow repos.

-- Jérôme

sloria commented 1 year ago

do you think you could add PYPI_API_KEY (and/or make me maintainer) so that we can proceed?

@lafrech you're already an admin on both--can you double-check that you have access?

lafrech commented 1 year ago

@sloria I'm talking about PYPI ownership. I don't see those in my list: https://pypi.org/user/lafrech/. So I can't create the API key.

sloria commented 1 year ago

@lafrech oh ok, i've given you access to apispec-webframeworks.

i can't give access to marshmallow-oneofschema since i'm not owner. @maximkulkin could you please make me and @lafrech owners of the pypi package here: https://pypi.org/manage/project/marshmallow-oneofschema/collaboration/

lafrech commented 1 year ago

Thanks. I just added PYPI_API_TOKEN to this repo.

lafrech commented 12 months ago

[x] Drop python 3.6 and 3.7 support
[ ] Replace pkg_resources with importlib.metadata
[x] Update versions used by pre-commit
[ ] Use modern packging based on pyproject.toml => Not sure. Unless we want to do this for all marshmallow repos. Consistency first.
[ ] Add support for python3.10/11/12 => I added 10 and 11. Let's add 3.12 as in https://github.com/marshmallow-code/marshmallow/pull/2188. Also, I added this repo to pre-commit CI so after we check it actually works we can modify workflow to only run lint on tags as in marshmallow.

Thank you for you help on this @kasium.

lafrech commented 11 months ago

Other TODOs:

[ ] setup.cfg: remove "universal" line
[ ] setup.cfg: review flake8 config, remove "select" and question other lines (compare with marshmallow and other libs here)
[ ] improve the way minimal versions of dependencies are provided (see https://github.com/marshmallow-code/webargs/blob/dev/setup.py for an example) and test minimum dependencies in a dedicated test to catch compatibility issues (https://github.com/marshmallow-code/webargs/blob/dev/tox.ini)

Quentin-Pinot commented 8 months ago

Hello,

Regarding the TODO: "Replace pkg_resources with importlib.metadata" i just made one PR about it.

kasium commented 8 months ago

@sloria thanks for the new version. In the changelog is missing, that this library is now a typed package. You might want to add this

sloria commented 7 months ago

@kasium good catch. updated in https://github.com/marshmallow-code/apispec-webframeworks/commit/980ac9d56e50efafb4d191bec51067f844c3cb7e