search

marshmallow-code / apispec-webframeworks

Web framework plugins for apispec (formally in apispec.ext).
MIT License
32 stars 23 forks source link

move tests outside src #67

Closed elfjes closed 4 years ago

elfjes commented 4 years ago

Is there a specific reason reason why the tests are located under src/? Would it not make more sense to take them to the root of the repository? At the current location the tests are packaged and distributed through pypi which, while not adding a lot to the wheel size, seems unnecesary to me.

lafrech commented 4 years ago

The reason for this is that those tests are run from apispec tests.

elfjes commented 4 years ago

Ah alright, I guess then it makes sense to package these tests

just out of curiosity, where/how are those tests run?

lafrech commented 4 years ago

Looks like they were lost (or intentionally dropped by @sloria) in https://github.com/marshmallow-code/apispec/commit/357023d63f2445e63c57dab0810c36dc6a6186c8.

elfjes commented 4 years ago

Thanks for finding that :)

That commit message sure makes it look like it was intentional: "NOTE: This removes builds against apispec-webframeworks"

which would mean that the tests no longer need to be packaged?

lafrech commented 4 years ago

The test in apispec was meant to let apispec developers realize when they introduce changes that break web frameworks extensions. Dependabot here can only realize that when the new apispec is packaged. It was also introduced as a transition when externalizing web-frameworks plugins.

I suppose @sloria doesn't intend to reintroduce it. So we can remove the tests from the package.

sloria commented 4 years ago

Yeah, with Azure Pipelines it was easier to set up periodic jobs (https://github.com/marshmallow-code/apispec-webframeworks/blob/f96faa292a45fd0aa5817ff9b1ea80d525de1f52/azure-pipelines.yml#L7), which sort of obviates running webframeworks tests in apispec.

I'm fine with removing the tests from the package.

lafrech commented 4 years ago

Oh, great.