search

marshmallow-code / flask-smorest

DB agnostic framework to build auto-documented REST APIs with Flask and marshmallow
https://flask-smorest.readthedocs.io
MIT License
639 stars 72 forks source link

Fix OpenAPI docs generation to include missing response headers when pagination is used #579

Closed drcpu-github closed 8 months ago

drcpu-github commented 8 months ago

PR for issue #578.

Added the code I showed in the issue and a simple test to show that it works. Not sure if you expect more from a test than this, but let me know.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (afaf1aa) 99.88% compared to head (05e34a2) 99.88%. Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #579 +/- ## ======================================= Coverage 99.88% 99.88% ======================================= Files 14 14 Lines 885 885 Branches 192 192 ======================================= Hits 884 884 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

drcpu-github commented 8 months ago

I have applied all suggestions, but did not yet squash the branch so you can check it more easily. I'll do that once you are happy with the changes.

drcpu-github commented 8 months ago

Just a typo to fix and you can squash.

Thanks!

Done!

lafrech commented 8 months ago

Released in 0.42.3. Thanks!