search

marshmallow-code / flask-smorest

DB agnostic framework to build auto-documented REST APIs with Flask and marshmallow
https://flask-smorest.readthedocs.io
MIT License
639 stars 72 forks source link

Fix type-hint in paginate method #593

Closed jtait closed 7 months ago

jtait commented 7 months ago

The type-hint in the current docs require an instance, not a class. This PR corrects that.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4cca4cb) 99.88% compared to head (df15d29) 99.88%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #593 +/- ## ======================================= Coverage 99.88% 99.88% ======================================= Files 14 14 Lines 885 885 Branches 192 192 ======================================= Hits 884 884 Partials 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lafrech commented 7 months ago

Right. We should implement actual type hints + mypy tests. Anyone willing to help with this is welcome.

Thanks for the correction.