marshsu / timthumb

Automatically exported from code.google.com/p/timthumb
0 stars 0 forks source link

staticflickr.com should be added to $ALLOWED_SITES #299

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Flickr have added a new image server domain, "staticflickr.com", which should 
be added to the default $ALLOWED_SITES array.

(Also, please consider namespacing this global variable, e.g. 
$timthumb_alloweddomains )

Original issue reported on code.google.com by p...@dharmafly.com on 5 Dec 2011 at 12:58

GoogleCodeExporter commented 9 years ago
e.g. image:
http://farm4.staticflickr.com/3613/3338093351_1e8eb5d20c.jpg
http://www.flickr.com/photos/viamoi/3338093351/

Original comment by p...@dharmafly.com on 5 Dec 2011 at 12:59

GoogleCodeExporter commented 9 years ago
thanks for the note. I have added the additional domain.

What's the thinking behind the namespace? The script isn't used with other code 
since it's a stand alone file. As such there's not really a need to apply a 
namespace to anything.

Original comment by BinaryMoon on 5 Dec 2011 at 9:55

GoogleCodeExporter commented 9 years ago
Thanks.

Regarding the namespacing, I may be reading the code wrong, but doesn't the use 
of `global $ALLOWED_SITES;` make this a global variable, and not one that is 
contained purely within the scope of TimThumb?

Original comment by p...@dharmafly.com on 6 Dec 2011 at 3:15

GoogleCodeExporter commented 9 years ago
Hello there, I have added this domain name to the whitelist myself using v 2.8 
of your script and the thumbnail isn't working! Could you please advise how I 
can resolve this?

Original comment by sheepdis...@gmail.com on 10 Jan 2012 at 7:49

GoogleCodeExporter commented 9 years ago
The URL is http://www.shaunhill.net/

At the bottom of the page with the scrolling portfolio.

Original comment by sheepdis...@gmail.com on 10 Jan 2012 at 7:50