search

marta-file-manager / marta-issues

An issue tracker for Marta File Manager.
https://marta.yanex.org/
366 stars 0 forks source link

Theme: add option to use native title bar #317

Open nhat opened 6 years ago

nhat commented 6 years ago

Please add an option to enable the old title bar like in previous screenshot from the documentation.

In general it would help Marta looks more like a native macOS app and make it easier to replace Finder.

nanoant commented 5 years ago

đź‘Ť please I believe this is vital feature, this would also help with #506 - distinguishing whether Marta window is active or not.

yanex commented 5 years ago

I would be glad to support the native title bar. However, I don't know where to place a progress bar for background operations then.

nanoant commented 5 years ago

@yanex There are few ways I can imagine:

  1. Really old school way with [[window standardWindowButton:NSWindowCloseButton] superview], many old apps used that to add some "Register me!" button.
  2. Using NSTitlebarAccessoryViewController and NSWindow addTitlebarAccessoryViewController available since 10.10 as explicit way to add stuff to title bar.
  3. Finally using 10.10 streamlined toolbar that gets collapsed into title when NSWindow.titleVisibility = false explained here in docs and in these WWDC 2016 slides. I think this would be my favorite one. It could also allow customizing and putting more stuff into the toolbar such as list mode, on off terminal, etc.
yanex commented 5 years ago

Wow, thanks for the suggestions! TBH, I didn’t investigate this properly before. I can’t guarantee this will be supported in the next version, but I will definitely look into this in the meantime.