search

marta-file-manager / marta-issues

An issue tracker for Marta File Manager.
https://marta.yanex.org/
359 stars 0 forks source link

Bug: `core.state.reset` resets the tutorial as well #896

Open chrisgrieser opened 2 years ago

chrisgrieser commented 2 years ago

I was considering to add "Cmd+Q" "core.state.reset" to my key-bindings, to make Marta always open at my default directory. However, it seems that core.state.reset also has the side effect of resetting the the tutorial state, every time I restart Marta after quitting with state-reset, the tutorial wizard opens up again.

I am not sure whether this is intended, but since core.state.reset does not reset anything else like configs, I assume this is a bug?

page-down commented 2 years ago

... to make Marta always open at my default directory ...

I think the best way to solve this problem should be to distinguish between "New Tab" and "Duplicate Tab". Please see the following link for more details.

https://github.com/marta-file-manager/marta-issues/issues/798

Only the "Duplicate Tab" action opens the current working directory again. This will match the "New Tab" behavior of many other software: do not duplicate the current tab.

... does not reset anything else like configs, I assume this is a bug?

I think this action works as expected. The configuration is not the saved state. But this action could perhaps have parameters added to choose only which states are reset, e.g. do not reset the tutorial state.