search

martaannaj / RecommenderServer

GNU General Public License v3.0
1 stars 2 forks source link

Run a go linter as a GitHub action #5

Closed reedy closed 2 years ago

reedy commented 2 years ago

For example:

https://github.com/golangci/golangci-lint

https://golangci-lint.run/usage/install/#ci-installation

Filed as part of https://phabricator.wikimedia.org/T292110

reedy commented 2 years ago

Can potentially do https://github.com/martaannaj/RecommenderServer/issues/4 as part of this issue

miselico commented 2 years ago

I have now added golangci-lint to the workflow. It did indicate some issues already, most of them seem trivial to fix. I have not investigated how to run tests with this yet.

miselico commented 2 years ago

Since 06c4a15 the linter is run as part of the github workflow upon creation of a pull request, merging into main and scheduled once every week on main.