compilation error fix for osx 10.11

martanne / dvtm

dvtm brings the concept of tiling window management, popularized by X11-window managers like dwm to the console. As a console window manager it tries to make it easy to work with multiple console based programs.

MIT License

853 stars 106 forks source link

compilation error fix for osx 10.11 #30

Closed spacelatte closed 7 years ago

spacelatte commented 8 years ago

there was an error in v0.15 where sigwinch seems to be 'undefined' within default includes in osx

actually seems available on sys/signal.h but doesn't compile.

added definition if not defined already.

homebrew patchfile: https://github.com/Homebrew/formula-patches/blob/master/dvtm/patch-vt.h-compat.patch

martanne commented 7 years ago

Thanks for the report, however hard coding this is not a good solution. I don't have access to a Mac OS X system, but according to Google SIGWINCH is available if _DARWIN_C_SOURCE is defined. This seems to be the case in the homebrew formula. Hence, I'm a bit puzzled as to why this would fail?

The following should work:

CFLAGS=-D_DARWIN_C_SOURCE make

spacelatte commented 7 years ago

yep, looks like that fixes it. going to update formula then...